Comments on: Performance history about StringBuffer/String with JDKs

By: Tom Copeland

Tom Copeland — Sat, 26 Nov 2005 03:14:58 +0000

Thanks!

By: stephane

stephane — Fri, 25 Nov 2005 10:32:24 +0000

Tom, that’s cool. Thanks for your informative comment. Keep up the good job on PMD !

By: Tom Copeland

Tom Copeland — Thu, 24 Nov 2005 04:36:57 +0000

Also, we’re adding “migration” rules to aid in migrating from one JDK version to another:

http://pmd.sourceforge.net/current/rules/migrating.html

Only a few simple ones in there so far (replace Vector with List, etc), but maybe I can add some of the things you’re talking about here…

By: Tom Copeland

Tom Copeland — Thu, 24 Nov 2005 04:35:43 +0000

Very interesting, Stephane, thanks for the information post. I’m just working through adding some new StringBuffer and String checks to PMD; for example, there’s this one:

http://sourceforge.net/tracker/index.php?func=detail&aid=1274198&group_id=56262&atid=479924

that finds code like:

String foo = rs.getString(“somefield”);
if (foo.toUpperCase().equals( “GENERIC” ) ){
}

rather than using String.equalsIgnoreCase(), and this one:

http://sourceforge.net/tracker/index.php?func=detail&aid=1295534&group_id=56262&atid=479924

which finds code like this:

void foo(StringBuffer sb) {
if (sb.toString().equals(“”) ){ // just use sb.length() == 0 !!
}
}

Never a dull moment…